-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rc chisel firrtl 3.4.1.x #742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump to pre-merge chipsalliance/rocket-chip#2764 to get it going while picking up the chisel/firrtl bugfixes in 3/1.4.1+
non-master pre-merge bump
timsnyder-siv
pushed a commit
to firesim/firesim
that referenced
this pull request
Dec 18, 2020
my previous bump duplicated an earlier PR
timsnyder-siv
added a commit
to timsnyder-siv/rocket-chip
that referenced
this pull request
Dec 22, 2020
Creating an intermediate commit for ucb-bar/chipyard#716 to use for CI until ucb-bar/chipyard#742 is merged and this bump will be subsumed by the larger bump.
Looks like once we have all of the submodule PR's merged, CI will be passing. |
Since chipsalliance/rocket-chip#2764 is marked as "SQUASH & MERGE WITH MERGIFY", there will need to be one more RC bump after that PR is merged. |
This was referenced Dec 23, 2020
jerryz123
added a commit
to riscv-boom/riscv-boom
that referenced
this pull request
Dec 23, 2020
NVM it looks like the RC PR wasn't squashed, it was just merged. Thanks @timsnyder-siv |
jerryz123
approved these changes
Dec 26, 2020
Merged
davidbiancolin
pushed a commit
to firesim/firesim
that referenced
this pull request
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that we just bumped to Chisel 3.4 in #719. However, there have been some bugfixes in Chisel/Firrtl and feature changes in RC since the versions from November that I'd like you guys to pick up. Starting a branch of Chipyard because there are some small fixes that need to be made across the repos.
Related issue:
Type of change: bug fix | new feature | other enhancement
Impact: rtl change | software change | unknown | other
Release Notes